search

ben-manes / gradle-versions-plugin

Gradle plugin to discover dependency updates
Apache License 2.0
3.86k stars 199 forks source link

Allow filtering configurations #785

Closed bh-tt closed 1 year ago

bh-tt commented 1 year ago

Closes #782

This needs someone with actual knowledge of kotlin/groovy to look at it, but the logic itself and the test is written.

bh-tt commented 1 year ago

I should probably add a few lines to the README detailing the new feature as well?

ben-manes commented 1 year ago

Oh yeah, that would be nice 🙂

bh-tt commented 1 year ago

I dont mind being given release access to this repository, but could you be a little bit more careful giving someone who spent about an hour on a minor feature full write access to the repository? If I had malicious intentions it would be easy to add some malicious code to the plugin and release a new version. Your plugin is used in quite a few projects I believe which makes it a prime target for a supply chain attack.

I do not need write access to the main repository to create a PR so I should not have it.

ben-manes commented 1 year ago

I appreciate the feedback. I think someone who discusses improvements on the issue tracker, contributes a feature, and writes tests should be given the benefit of being trusted. Otherwise I wouldn't have invited you as a contributor.

bh-tt commented 1 year ago

Forgot to update the version, I've deleted the v0.47.0 tag and release and recreated it.

Might be good to add a 'how to release' section to the readme?

bwmeier commented 1 year ago

Thank you for working on this @bh-tt ! I really appreciate the feature!