search

ben-miles / nomansguide

An unofficial second-screen companion app for the game "No Man's Sky."
https://nomansguide.dev
Other
3 stars 1 forks source link

Add Filtering Buttons to Translator View #24

Closed ben-miles closed 1 year ago

ben-miles commented 1 year ago

The new Translator works like I'd originally planned, but it might be a bit better to have a set of buttons to allow for filtering by language (eg, only show translations from Gek, or only from Korvax, or from All) -- Similar to the category buttons on the Items view.

I started building this, but commented it out so I could get 3.0 released without additional delays. The problem that's holding me up right now is finding a way to conditionally filter by language -- my JSON data files for this are already split up by language, so the entries don't contain the name of the language itself... Probably just need to pass a second param to the filter that contains a string of the language, then I can compare that against the currently selected language from the buttons.

Bonus points for breaking these buttons out into their own SFC, so I can re-use them in the Items view.

ben-miles commented 1 year ago

Closed by df7c4c4ade85abdb04319f92f221ee5f1239b2de