search

ben-ng / add

A cross-browser, numerically stable algorithm that adds floats accurately in Javascript
https://www.npmjs.org/package/add
45 stars 13 forks source link

RangeErrors #7

Open ArsalanDotMe opened 9 years ago

ArsalanDotMe commented 9 years ago

This module causes RangeErrors when used with package linear-algebra. Perhaps too many recursions?

ben-ng commented 9 years ago

This might be a bug in the implementation. If you can give me a breaking test case I can see why.

ArsalanDotMe commented 9 years ago

I don't know at what point the code breaks. Going through your source code my suspicion is that the transform function is going into too many recursions. Other than that, I'm clueless. I'll post the sourcecode of my short program if you want to test it and see. https://github.com/ArsalanDotMe/summarizer/tree/master

ben-ng commented 9 years ago

In this case I suggest using another linalg library. Numeric.js is a good one.