Open ghost opened 8 years ago
Here is a few more bugs:
suite.js
. You are setting the name in the report, but no validation if the name is null, undefined or not a string.
Suite.prototype._getReport
never invoked as far as I could figure out. And isn't that function reduntant? You have already set the report with the name. How can it not be a report object?Same function is pointing to a non-existing this._err
that is never used.
@ben-page I found a few more bugs, and a few other things.
instanceOf
causes a DEOPT in Chrome and should be avoided. Your code: https://github.com/ben-page/node-test/blob/dev/lib/test.js#L60I really enjoy reading your code! Amazing good work! And the result are just stunning!
Keep up the good work!!!!
Due to changes in nodeJS v5.4
you should use 1e9
and normaliize the source array for hrtime
.
I can't remember exactly where I was reading that, but see NodejS documentation:
https://nodejs.org/api/process.html#process_process_hrtime_time
They are also using 1e9
use of instanceOf causes a DEOPT in Chrome and should be avoided.
Will you provide a source for this? I can't find anyone recommending that instanceOf
be avoided.
I spoke with a colleague of mine and this DEOPT was caused by hidden classes etc with V8 that Chrome uses. He should search for links regarding this
Hey! I saw your latest changes, and this starts to be a awsome runner!! I'm impressed. However I found bugs!
this._err;
but this doesn't exist, and are not used inside the code? Same thing for hook.jsthis._test._validateFailure
it doesn't exist for the Hook.Not a bug, but after looking at AVA and tape source. Why are you passing
this
from Suite to test, and not keeping this functions within the test module?Quick question. Why need for a new Runner prototype for the reporter? And how are you going to add in different reporters?