search

ben-rogerson / craft-gulp

🎨 Craft CMS + SCSS + JS + Gulp > A full set of build-tools for Craft website developers
MIT License
3 stars 0 forks source link

Start building a core set of JS modules #6

Open ghost opened 6 years ago

ghost commented 6 years ago

Make them super-duper descriptive, like

UpdateBodyHelperClassesOnResize UpdateBodyHelperClassesOnScroll UpdateBodyHelperClassesOnLoad TransitionInElementsOnScroll InjectInlineSVGs OpenMenuWhenBurgerClicked SkinVideos FlexPolyfill StickyPolyfill

...Then import them into your main entry point and comment out if not needed for certain jobs.

ben-rogerson commented 6 years ago

Every module included in a boilerplate should be jQuery free. This isn't Wordpressland so we could potentially push sites without the framework. What do you think?

ghost commented 6 years ago

Yeah I hear ya, we’re on the same page. I generally assume jquery as the non-negotiable dependency in most agencies whether we love it or hate it (the idealist in me is firmly in the latter camp)... but if you’re open to excluding jquery and going vanilla is then I’m totally on board. All of those module suggestions can be done without too much extra shim code.

Are there any deps you would still include as non-negotiable then? Lodash?

On Tue, 28 Aug 2018 at 11:09 am, Ben Rogerson notifications@github.com wrote:

Every module included in a boilerplate should be jQuery free. This isn't Wordpressland so we could potentially push sites without the framework. What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ben-rogerson/craft-gulp/issues/6#issuecomment-416422583, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7iogfYd1TT7oB_oz6tUhrK9TSya8rcks5uVJ9bgaJpZM4WOsau .

--

Regards,

Aaron McCaffery Interactive Designer Ignite Media

M: +61 415 408558 W: ignitemedia.com.au

ben-rogerson commented 6 years ago

Lodash would be great to include by default as it lets you cherry pick the bits you need

ghost commented 6 years ago

Yeah that's exactly why I like it too. Super lightweight in that way

--

Regards,

Aaron McCaffery Interactive Designer Ignite Media

M: +61 415 408558 W: ignitemedia.com.au

On 28 August 2018 at 18:56, Ben Rogerson notifications@github.com wrote:

Lodash would be great to include by default as it lets you cherry pick the bits you need

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ben-rogerson/craft-gulp/issues/6#issuecomment-416514657, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7iohlIlJ4ljKCDnxVuoaWLmvWFItg_ks5uVQzHgaJpZM4WOsau .