Downshift is not being used correctly in JMultiSelect

ben-ryder / jigsaw

A design system and component library for use in my personal projects.

https://jigsaw.benryder.dev

GNU General Public License v3.0

0 stars 0 forks source link

Downshift is not being used correctly in JMultiSelect #60

Closed ben-ryder closed 10 months ago

ben-ryder commented 1 year ago

Describe the bug When using the JMultiSelect component there are a number of errors being generated by downshift.

Screenshot from 2023-10-18 22-20-11

Version and Environment What version of the package has the bug? What device/browser/application are you seeing the issue with? current

Additional context

Possibly need to update form components to pass and use ref correctly. This may be required anyway for using them in form libraries like react-hook-form.

ben-ryder commented 1 year ago

I think the issues with getMenuProps and ref is because I conditionally render the menu, but instead I should always render to menu and then show/hide via CSS instead. This will probably help if/when adding transitions and animations in the future too so win win!

The aria controls not matching the server requires further investigation, but assuming the ids match client side it may just be ok to ignore and allow the value to be different at client hydration.

ben-ryder commented 10 months ago

fix released in v0.17.0