search

ben-strasser / fast-cpp-csv-parser

fast-cpp-csv-parser
BSD 3-Clause "New" or "Revised" License
2.12k stars 439 forks source link

remove unused parameter (and its warning) #38

Closed pboettch closed 6 years ago

pboettch commented 7 years ago

clang 5.0 with -Wunused-parameter produced the following warning:

../external/csv/fast-cpp-csv-parser/csv.h:1076:33: warning: unused parameter 'col' [-Wunused-parameter] void parse(charcol, T&x){ ^ ../external/csv/fast-cpp-csv-parser/csv.h:1076:40: warning: unused parameter 'x' [-Wunused-parameter] void parse(charcol, T&x){ ^ This patches fixes it.

Seen with clang 5.0.0-svn294894-1

ben-strasser commented 6 years ago

Thanks for the patch. The issue was resolved by adding "(void)x"-style instructions to silence the compiler.