ben-wallis / Filtration

The Path of Exile loot filter editor
GNU General Public License v2.0
262 stars 61 forks source link

Throttle selections to improve Select All performance. #104

Closed GlenCFL closed 5 years ago

GlenCFL commented 5 years ago

This drastically improves the performance of selecting all blocks within an item filter through Ctrl + A. The program would essentially lockup for dozens of seconds previously if you selected all blocks in a filter like NeverSink, with this being instantaneous.

I've added Reactive Extensions and DynamicData as package dependencies. This adds about 3MB of binary and XML data to the build, which is the downside to this approach given that we just need to debounce events coming from the ObservableCollection.

ben-wallis commented 5 years ago

Nice fix - hadn't noticed that this was an issue. Also it only adds about 800kb to the install size since the .xml files aren't included in the distributed setup file.