search

ben-wallis / Filtration

The Path of Exile loot filter editor
GNU General Public License v2.0
262 stars 61 forks source link

Input deadzone within each block view. #105

Closed GlenCFL closed 5 years ago

GlenCFL commented 5 years ago

Within the view for each block, there is a zone with no elements that eats input, whether it's a click or a scroll. Right clicking within this area will still select the block and show the contextual menu for it. This area is particularly annoying because if you open a block and then decide to scroll upwards or downwards, then that input may simply be ignored. This makes the program seem sluggish and unresponsive.

This area is marked in red here: input-deadzone

GlenCFL commented 5 years ago

The container that holds each of the block elements is what is eating input.

input-deadzone-revised

ben-wallis commented 5 years ago

Fixed - it was caused by the ScrollViewer I added for when there are too many block items to fit horizontally handling the mouse wheel events.

GlenCFL commented 5 years ago

I came to a similar solution shortly after submitting this, but the issue with that approach is that it disables scrolling for any children as well. As a result, the values for the Class and BaseType rules no longer scroll.

I didn't know enough about WPF to know how to fix that.

ben-wallis commented 5 years ago

Ah didn't notice that - fixed in 6fb0ec80 with a special case exception for mouse wheel events that originated within an EditableListBoxControl