search

ben-wallis / Filtration

The Path of Exile loot filter editor
GNU General Public License v2.0
262 stars 61 forks source link

the 'Advanced' button in color sections and the sound icon (for play sound alert) does not work #115

Closed leeroypoe closed 5 years ago

leeroypoe commented 5 years ago

As said in the title, when editing the color (text color, background color or border color) cannot click on 'Advanced' to tune the color, i can only pick one of the predefined colors. Also the play sound alert icon does not play the selected sound alert.

ben-wallis commented 5 years ago

Which version did you have this issue in? The sounds not playing should have been fixed in 1.1.0-beta5

ben-wallis commented 5 years ago

Could you explain the colour picker issue more? I just tried it in 1.1.0-beta6 and it seems to work fine:

image

GlenCFL commented 5 years ago

@ben-wallis try selecting advanced on a color picker in "Edit Master Theme"

leeroypoe commented 5 years ago

Hi Ben, I have the v1.1.0 - beta2. I apologies, i think it was the latest one available. As i see on the picture you are posting the color 'Advanced' tab work. How can i get the latest version (beta) ? Cant find a link for it. Thank you in advance.

GlenCFL commented 5 years ago

The releases page has a link to each installer. Only one of your issues, the sounds not working, is fixed in the latest beta though. A new version will likely be released once the other issue is resolved. As a side note, you can go to File -> Settings to enable automatic pre-release updates.

These issue reports are appreciated if you do encounter any more issues in the future.

ben-wallis commented 5 years ago

This issue is fixed in 1.1.0-beta7 which has just been released

GlenCFL commented 5 years ago

@ben-wallis Just confirmed it. Good work on the quick fix.

leeroypoe commented 5 years ago

Thanks, perhaps i can not download the new version via the autoupdate function in 1.1.0-beta2. It show new version avalable click to download. When i click it start downloading then show 25% and immediately show in red "An error occured while che...." Update Error - Check Logs, but i there is no log file in the folder, only the Filtration 1.1.0-beta2.exe file.

On Wed, 5 Dec 2018, 18:45 Ben Wallis, notifications@github.com wrote:

This issue is fixed in 1.1.0-beta7 which has just been released

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ben-wallis/Filtration/issues/115#issuecomment-444577088, or mute the thread https://github.com/notifications/unsubscribe-auth/ArWxQMK4dRBOrazFlyN_ueKnhp9yhMcmks5u2AZAgaJpZM4ZDGOC .

GlenCFL commented 5 years ago

That sounds like what used to happen with #93. I'll grab an older version and try to update now.

ben-wallis commented 5 years ago

Yeah the auto-update for some early 1.1.0 betas are broken, the deltas got corrupted during uploading or something. It's been working since 1.1.0-beta4 I think

leeroypoe commented 5 years ago

I also disable my AV (avast) but same error aucure

On Wed, 5 Dec 2018, 18:52 yuli CG, 066082@gmail.com wrote:

Thanks, perhaps i can not download the new version via the autoupdate function in 1.1.0-beta2. It show new version avalable click to download. When i click it start downloading then show 25% and immediately show in red "An error occured while che...." Update Error - Check Logs, but i there is no log file in the folder, only the Filtration 1.1.0-beta2.exe file.

On Wed, 5 Dec 2018, 18:45 Ben Wallis, notifications@github.com wrote:

This issue is fixed in 1.1.0-beta7 which has just been released

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ben-wallis/Filtration/issues/115#issuecomment-444577088, or mute the thread https://github.com/notifications/unsubscribe-auth/ArWxQMK4dRBOrazFlyN_ueKnhp9yhMcmks5u2AZAgaJpZM4ZDGOC .

leeroypoe commented 5 years ago

Thank you for all the work you do. I like this tool so much :)

On Wed, 5 Dec 2018, 18:54 Ben Wallis, notifications@github.com wrote:

Yeah the auto-update for some early 1.1.0 betas are broken, the deltas got corrupted during uploading or something. It's been working since 1.1.0-beta4 I think

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ben-wallis/Filtration/issues/115#issuecomment-444580323, or mute the thread https://github.com/notifications/unsubscribe-auth/ArWxQF3Vb7JnkVKnaqAha7UVWPBEzsZtks5u2AhzgaJpZM4ZDGOC .

GlenCFL commented 5 years ago

1.0.0-beta5 was the first that worked, so yeah it's the delta corruption. You'll have to manually download the latest version.

leeroypoe commented 5 years ago

Thank you, ive got the v 1.1.0-beta7. Seem to work well. Thank you again and have a good night.

On Wed, 5 Dec 2018, 18:58 Glen M, notifications@github.com wrote:

1.0.0-beta5 was the first that worked, so yeah it's the delta corruption. You'll have to manually download the latest version.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ben-wallis/Filtration/issues/115#issuecomment-444581616, or mute the thread https://github.com/notifications/unsubscribe-auth/ArWxQJMYGijjTSncpNNHJJoZVtIZAmnZks5u2AlQgaJpZM4ZDGOC .