Add possibility to disable Block(s) with Block Groups (instead of hide)

[Asymat]

When you uncheck a block group in the block group browser, sometimes you just want to "not style an item" instead of "hiding an item" (as it may get catched later on by another block).

I think this would open a brand new way for users to manage their lootfilter with the Block Group Browser (and thus for lootfilter editors to edit block groups). I can see it good for leveling stuff, recipes, high bases...

[Asymat]

On a side note, commenting blocks improves performances of lootfilters. ;)

Allow me to emphasize the importance of this option. Lootfilter developers need a way to tell if checking out a block group in the block group browser means commenting or hiding blocks. It is a big limitation of the block group browser and thus of users customizing their lootfilter.

[Greengroove]

+1

https://www.reddit.com/r/pathofexile/comments/5ftpbg/lootfilter_performance_tips_thanks_to_the/

[Asymat]

[Robotic voice ON] @Greengroove I was actually searching how to add a user to the thread and ask your thoughts. What a coincidence! :)

[Greengroove]

This option would be a Huge improvement! It would bring my and other filters to the next level. It could potentially be a huge boost to performance as well. If I could do some awesome things with such a feature! Stuff that now can't be done and it's bugging me.

[Greengroove]

Well It would be nice to hear from Ben about this. I see this option is already possible within each block. But what we need is toggles like the ones in the block group browser, to be able to quickly set up the filter.

I already have some ideas how could the UI look like. I am willing to help in any way possible to make this a thing. Note that the picture is just a thought I had...

@ben-wallis

[Asymat]

I think it should be programmatically (ie by lootfilter editers) set up : hide or comment block for every blocks in the block group. That way a user won't mess up by mistake (like commenting out portal scrolls instead of hiding them). Users will only check or uncheck block groups.

PS: I don't see a use case where you want to comment AND hide a block?! (But I can see a case where you want to hide some blocks and comment others in the same block group).

@ben-wallis, we are dying here! Please give us your thoughts!

[Greengroove]

@Asymat

FYI This is brand new: http://filterblast.oversoul.xyz/

The author introduces advanced syntax, including commenting and disabling entries like you propose, as well as some other nice stuff. I believe he wrote to Ben already. The advanced syntax is made so that it will be compatible with both Filtration and POE without the need of parsing the script.

[Greengroove]

Hope this gets fixed soon. My filter is currently not compatible with Filtration cause of this.

https://github.com/Greengroove/GG-LootFilter/issues/4

[DerrickRice]

Hey @ben-wallis , what else can I do to help get this included in the latest version?

Alternatively, I can offer up a version through my repo, but I'm thinking you'd prefer to keep your own version alive and not create confusion with forks.

[Greengroove]

@DerrickRice How about making a temporary repo until Ben is back? I think Filtration is still a great tool, and I would love to use it for quick edits. This app has a gpu 2.0 license which means it is free to modify and distribute it so long as you respect the terms (term 2).

But anyways only do it if you need to... Just lmk if you do. :) Thanks again and gl in Legacy.

Btw: Here is the (probably) final version of my filter for 2.6 http://filterblast.oversoul.xyz/advanced/Template/rqanmk

[azakhi]

@ben-wallis Maybe we can change hide/show to enable/disable?

[Greengroove]

@azakhi It is not about changing one to another, but rather tell the application how to know if it has to do one or the other.

For reference: https://github.com/Greengroove/GG-LootFilter/issues/4#issuecomment-418343431