Support season tag - Githubissues

ben-xo / dir2cast

Turn a directory of MP3s into a podcast - automatically.

http://www.ben-xo.com/dir2cast

BSD 3-Clause "New" or "Revised" License

152 stars 20 forks source link

Support season tag #65

Closed EdwarDDay closed 1 year ago

EdwarDDay commented 1 year ago

It would be nice to have support for the season tag. iTunes supports <itunes:season> as an optional episode tag and there is the TPOS (part_of_a_set) ID3 tag which could be used.

ben-xo commented 1 year ago

This is an interesting idea, i'll look into this!

Can you give me an example of what content you'd fill in the tag with?

EdwarDDay commented 1 year ago

When I look at Apples Podcaster's Guide to RSS there is the definition of <itunes:season>

The episode season number.

If an episode is within a season use this tag.

Where season is a non-zero integer (1, 2, 3, etc.) representing your season number.

To allow the season feature for shows containing a single season, if only one season exists in the RSS feed, Apple Podcasts doesn’t display a season number. When you add a second season to the RSS feed, Apple Podcasts displays the season numbers.

So a non-zero positive integer should work.

ben-xo commented 1 year ago

Implemented here: https://github.com/ben-xo/dir2cast/pull/68 - would you be so kind as to try it out @EdwarDDay ?

EdwarDDay commented 1 year ago

Thanks @ben-xo . I tested it and found out, that just adding a <itunes:season> element isn't enough. The whole podcast needs a <itunes:type>serial</itunes:type> and every episode needs an episode number <itunes:episode>.

My idea for continuing would be the following: Adding <itunes:type>serial</itunes:type> based on ITUNES_SEASON_TAG in the ini file would make sense in my opinion. The episode number could either be calculated or read from TRCK tag (Track number/Position in set).

ben-xo commented 1 year ago

Hi @EdwarDDay , I have updated the branch as so:

config renamed to ITUNES_TYPE_SERIAL
when set, <itunes:type>serial</itunes:type> will be output.
TRCK now used for <itunes:episode> as well as TPOS for <itunes:season>. If missing, won't be output.

Could you try this version?

ben-xo commented 1 year ago

I've updated the config to e.g. ITUNES_TYPE = serial with the default being episodic so that you have the option to remove it entirely with ITUNES_TYPE = ""

EdwarDDay commented 1 year ago

@ben-xo I tried it and it works perfectly. Thank you