Open MichielvanBeers opened 11 months ago
@ben-xo I just noticed that my commit isn't signed yet. I don't believe I can do that for code that is already committed. Shall I do a new PR?
@ben-xo I just noticed that my commit isn't signed yet. I don't believe I can do that for code that is already committed. Shall I do a new PR?
Not unless you want to - it'll be signed by me when it gets merged in anyway 👍
@ben-xo then I'll leave it like this :). Let me know if you have feedback on the PR!
@ben-xo then I'll leave it like this :). Let me know if you have feedback on the PR!
I'll do you a code review since I do them regularly for my team at Mixcloud. :)
I've extended your PR in this one: https://github.com/ben-xo/dir2cast/pull/74 - that's the one i'll merge, with credit
@ben-xo nice, very impressive! Thanks for adding all the tests and additional documentation :)
Adding the ability to add a title.txt to the MP3 folder would set the title of the podcast. Adding this since I have some podcasts with spaces in the title, but when trying to load the iTunes image, this wouldn't always play nice.
Previous Folder:
/localdir/some podcast with spaces/
URL podcast:www.base-url.com/some%20podcast%20with%spaces
Itunes image:www.base-url.com/some%20podcast%20with%spaces/itunes_image.jpg
Current Folder:
/localdir/somepodcastwithoutspaces/
Title.txt:Some podcast with spaces
URL podcast:www.base-url.com/somepodcastwithoutspaces
Itunes image:www.base-url.com/somepodcastwithoutspaces/itunes_image.jpg