search

ben-xo / dir2cast

Turn a directory of MP3s into a podcast - automatically.
http://www.ben-xo.com/dir2cast
BSD 3-Clause "New" or "Revised" License
155 stars 22 forks source link

Add working dockerfile and update readme #77

Open ctkcoding opened 9 months ago

ctkcoding commented 9 months ago

Add Dockerfile to allow build to docker image and update readme's docker install instructions

ctkcoding commented 9 months ago

Built the referenced docker container and pushed to https://hub.docker.com/repository/docker/ctkcoding/dir2cast

ctkcoding commented 9 months ago

@ben-xo not seeing the option to request a review like I'm used to, so tagging you in the comments here instead

ben-xo commented 9 months ago

Hey, thanks for this.

I have some feedback, which I'll leave as a review. However it's worth noting that dir2cast already has a docker example (using nginx and php-fpm) - checkout the docker-compose.yml file already in the repo. I guess it doesn't really work the same way, and there are pros and cons - and personal preferences - to both approaches. Also I guess the current example isn't actually documented in the README.

e.g do you want dir2cast and config on your filesystem or hidden within the container? are you more of an Apache guy or a Nginx fan? (i'm the latter, but I am not a php-fpm fan so it kind of cuts both ways).

Anyway i'll leave you a proper review next.

ctkcoding commented 9 months ago

Thanks for the feedback - will clean up & address over the weekend! Also re why I'm not into docker compose - I run all my docker apps using images from docker hub and it's more convenient accessing it through a gui on my laptop than sshing in to the server itself to manage things. Re apache vs nginx - my real preference is dealing with a single port on my host machine because it's all abstracted by docker

ben-xo commented 9 months ago

Thanks for the feedback - will clean up & address over the weekend! Also re why I'm not into docker compose - I run all my docker apps using images from docker hub and it's more convenient accessing it through a gui on my laptop than sshing in to the server itself to manage things. Re apache vs nginx - my real preference is dealing with a single port on my host machine because it's all abstracted by docker

docker-compose is supported by both OrbStack and the official Docker desktop app, as far as i know!

ctkcoding commented 7 months ago

@ben-xo updated to address feedback

ctkcoding commented 7 months ago

@ben-xo any comments/feedback on the latest version or does this look good to merge?

ctkcoding commented 1 month ago

@ben-xo ?