ben / foundry-ironsworn

Ironsworn and Starforged, for Foundry VTT
Other
70 stars 43 forks source link

organize RollableTables into directories (v10) #387

Open rsek opened 2 years ago

rsek commented 2 years ago

it doesn't allow for unlimited depth - the maximum appears to be 3 deep.

Screen Shot 2022-06-12 at 6 39 07 PM

for Ironsworn classic, that's plenty, but for starforged it may present some challenges.

i'm still considering how best to approach that. my current thought is dumping the categories in the top-level of the sidebar...

and that seems all right (i don't think any SF categories get deeper than that, but i'll need to double check). that would mean dividing the oracles into individual compendium packs by category. i could see some upsides to that - more modularity for people who only want certain oracles from either game, for one. however, importing 13 categories one by one doesn't sound especially fun. maybe the best solution there would be a user-facing helper to import them all at once, for the best of both worlds?

i'm curious about the implications of this on the current oracle tree sidebar, too. πŸ€”

rsek commented 2 years ago

good news: it preserves the directory hierarchy when filtering results 8D

Screen Shot 2022-06-12 at 7 31 50 PM
rsek commented 2 years ago

bad news: filter text doesnt take dirname into account when filtering, so the filter text of "AAaaAAA" in the example above returns nothing. that's probably a dealbreaker, as far as it being a useful way to browse Starforged's oracles.

i've opened an issue for it: https://github.com/foundryvtt/foundryvtt/issues/7282

rsek commented 2 years ago

will probably require this (FWIW, it has the 2nd highest weight among all v10 items, so it seems like a good bet): https://github.com/foundryvtt/foundryvtt/issues/1109

ben commented 2 years ago

Same comment as in #388: I don't disagree with the value proposition here, but yeah, it would require compendia to support folder structures, which they currently don't. The last comment on that issue was 18 months ago, so I'm not holding my breath that we'll get it in v10, given where we are in that release cycle. Maybe v11?

rsek commented 2 years ago

looks like it's no longer intended for v10. removing the "requires v10" label https://github.com/foundryvtt/foundryvtt/issues/1109#issuecomment-1167708382