search

ben519 / mltools

Exploratory and diagnostic machine learning tools for R
Other
72 stars 26 forks source link

Update auc_roc.R #10

Closed MichaelChirico closed 6 years ago

MichaelChirico commented 6 years ago

maybe add data.table::uniqueN to be explicit? Checked and it's available since 1.9.6.

Also might consider using DT to minimize collision potential with stats::dt.

I suppose there's also some optimization to be had in the case where uniqueN(preds) == length(preds), is that right?

MichaelChirico commented 6 years ago

Hmm, indeed I saw that myself and seem to have let it slip my mind! Reverted that part. I added a note to the data.table issue to revisit.