ben519 / mltools

Exploratory and diagnostic machine learning tools for R
Other
72 stars 26 forks source link

Added support for multiclass MCC #11

Closed fanli-gcb closed 6 years ago

fanli-gcb commented 6 years ago

Using the definition provided here: http://journals.plos.org/plosone/article?id=10.1371/journal.pone.0041882

fanli-gcb commented 6 years ago

Hi @ben519 I've re-added the TP/FP/TN/FN arguments and sped up both the multiclass and two-class versions. The two-class version now actually just uses your original code, so the speed should be almost identical.

BEFH commented 6 years ago

I would like to see this in the official version

ben519 commented 6 years ago

Hey, I'm sorry for being slow to react to this. I promise to review it this weekend.

BEFH commented 6 years ago

Is there a way to directly put in the confusion matrix? I have a 3 by 3 confusion matrix from another program which I want to process. On Wed, Apr 4, 2018 at 5:05 PM Ben notifications@github.com wrote:

Hey, I'm sorry for being slow to react to this. I promise to review it this weekend.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ben519/mltools/pull/11#issuecomment-378745031, or mute the thread https://github.com/notifications/unsubscribe-auth/ADOs6F2x10JDA3udXywrz91pIp-ledngks5tlTWpgaJpZM4REF24 .

ben519 commented 6 years ago

Hey guys, I'm closing this but let's move the discussion to #15. I re-implemented mcc with support for multiclass and confusion matrix. Would appreciate you all testing my work. Thanks and sorry for the delay.