search

ben519 / mltools

Exploratory and diagnostic machine learning tools for R
Other
72 stars 26 forks source link

Add one Boundary #17

Closed cycks closed 5 years ago

cycks commented 5 years ago

I have added the to the types of boundaries created when using the boundaryType function. I wanted to have a boundary like [1282.708, 48687.58] converted to 1282.708_to_48687.58, which is a string. Sorry, I have not taken time to read and understand the code or test my changes but you should be able to do it.

ben519 commented 5 years ago

Thanks for the PR, but I think this is not a good fit for the package.

  1. "1282.708_to_48687.58" makes it unclear as to whether the boundaries are inclusive or exclusive.
  2. This seems like a very specific functionality that only you will need. As such, you should do this externally (outside of mltools).

Cheers