hide inlined frames - Githubissues

benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)

Apache License 2.0

2.76k stars 118 forks source link

hide inlined frames #119

Closed bruno-garcia closed 3 years ago

bruno-garcia commented 3 years ago

Resolves: #118

Since you put the runtime to check first for AggressiveInlining and after that to the StackTraceHiddenAttribute, I've lifted the latter to the top to keep the same sequence. The rest of the checks stayed as they were. Let me know if this works for you.

Regarding testing against .NET 5:

A few tests break so would need some changes in behavior.
net46 on Mono (I'm on a mac) also fails even without any changes. Is there a goal to make it pass there?
The repo AppVeyor build seems broken. Is there an interest to move to GH actions?

benaadams commented 3 years ago

A few tests break so would need some changes in behavior.

This is ok; less is more :)

net46 on Mono (I'm on a mac) also fails even without any changes. Is there a goal to make it pass there?

Would be happy if it did :)

The repo AppVeyor build seems broken. Is there an interest to move to GH actions?

Very much; I was just reading the docs; but am not very familiar with it. Still at mostly pressing the "template" buttons stage with other projects

bruno-garcia commented 3 years ago

I've got GH actions on a few repos so I might be able to help on this.

Let's see during the week. I don't like to promise because time is short and I've got some hobby projects (one which involved copying a bunch of ur code, wanted to let you know).

benaadams commented 3 years ago

Thank you!

benaadams commented 3 years ago

Updated the tests for new frameworks

benaadams commented 3 years ago

Also added GitHub testing https://github.com/benaadams/Ben.Demystifier/pull/123

bruno-garcia commented 3 years ago

Oh thanks! Just saw all the changes :) Looking great,thanks!