search

benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)
Apache License 2.0
2.75k stars 118 forks source link

ns2.1 and TryResolveStateMachineMethod #125

Closed bruno-garcia closed 3 years ago

bruno-garcia commented 3 years ago

it's an easy change to discuss while looking at the change.

Nice CI is there! 🚀

benaadams commented 3 years ago 
Feature 'nullable reference types' is not available in C# 7.3. Please use language version 8.0 or greater.
Feature 'static local functions' is not available in C# 7.3. Please use language version 8.0 or greater.

Is lang latest conditional based on TFM?

bruno-garcia commented 3 years ago

It "works on my machine" as it builds here. ~I assume it requires net5 installed.~

I see CI has it:

      - name: Install .NET SDK 5.0
        uses: actions/setup-dotnet@v1
        with:
          dotnet-version: '5.0.x'
bruno-garcia commented 3 years ago

I'll remove it

bruno-garcia commented 3 years ago

Oddly enough only failed on Ubuntu

benaadams commented 3 years ago

I'm going to check my casing in another project I have that was having the same issue with nullability 😅

benaadams commented 3 years ago

Also a test to show its doing something? (Resolving the Iterator)

benaadams commented 3 years ago

Thank you :)