search

benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)
Apache License 2.0
2.75k stars 118 forks source link

Thoughts on `<Nullable>enable</Nullable>` ? #126

Closed bruno-garcia closed 3 years ago

bruno-garcia commented 3 years ago

What are you thoughts on enabling nullability checks? Would remove the Debug.Asserts in the process. Make porting code from the runtime easier.

benaadams commented 3 years ago

Am happy with it though looks like has targeting issues? https://github.com/benaadams/Ben.Demystifier/pull/125#issuecomment-753649679

bruno-garcia commented 3 years ago

@benaadams I copied code over which is annotated and didn't remove it. Will do now.

Adding NRT would land as a separate PR then. 👍

bruno-garcia commented 3 years ago

136