Add .pdb files to GitHub & NuGet releases

benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)

Apache License 2.0

2.75k stars 118 forks source link

Add .pdb files to GitHub & NuGet releases #142

Closed ghost closed 3 years ago

ghost commented 3 years ago

I have to debug this library and all I have is the .dll (no .pdb, so I'm unable to debug in rider). It would be nice if the pdb came with the dll so I don't have to build it myself to be able to debug it.

samtrion commented 3 years ago

The project already supports SourceLink for Github, so this should not be a problem.

benaadams commented 3 years ago

As well as the source and sourcelink the pdb is embedded in the dll so it should be debuggable?

ghost commented 3 years ago

That is very strange... Every time I've tried to debug I always get 'could not resolve method' and my breakpoints are never hit. One thing though is that I'm using it with Unity so there's possibly a chance of that causing some issues.

The main reason I've been trying to debug is because whenever I try to .Demistify() exceptions nothing changes, and I was trying to figure out why, Some of your other code works though (like new EnhancedStackTrace(oldStackTrace) and stringBuilder.AppendTypeDisplayName()).

bruno-garcia commented 3 years ago

@EternalClickbait what are you using for debugging? Visual Studio, Rider? And what version?

ghost commented 3 years ago

@EternalClickbait what are you using for debugging? Visual Studio, Rider? And what version?

Rider, 2020.2.4, I'm usingBen.Demistyfier 0.1.6 (what my package manager automatically game me) @bruno-garcia

ghost commented 3 years ago

Update: I'm unable to break at most lines. The only 2 I'm able to are the beginning/entrance of the method, and the start of the try block.

Update 2: The debugging and breakpoints are.....funky. The editor breaks but at the wrong locations: I set the breakpoint at the entry of the try, it supposedly broke at the entrance to System.Diagnostics.StringBuilderExtentions.AppendDemystified(this StringBuilder builder, Exception exception), but the stack shows the ctor for a System.Diagnostics.ValueTupleResolvedParameter. It also repeatedly breaks multiple times, even when the method is called only once (I've made sure of it).

ghost commented 3 years ago

@bruno-garcia @benaadams @samtrion

I think it was probably an issue caused by an old version of this library. I updated Rider to 2020.3.0 which did nothing, but as soon as I updated the library to 0.3.0, I immediately got my nice lovely stack traces back, and was able to debug properly. I'm now going to close this issue as I believe it is solved.