search

benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)
Apache License 2.0
2.75k stars 118 forks source link

build in sentry csproj #143

Closed bruno-garcia closed 3 years ago

bruno-garcia commented 3 years ago

Changes I had to make to build and test inside the Sentry SDK.

I'm hoping to clean up the changes here and merge it back upstream, if possible. I suspect the strict flag is what drove some of the changes, unsure yet since it also builds against net5.0 here.

Sentry PR: https://github.com/getsentry/sentry-dotnet/pull/732

bruno-garcia commented 3 years ago

@benaadams Trying my luck. Any blockers you identify to get this merged?

🙏

benaadams commented 3 years ago

Merged

benaadams commented 3 years ago

I assume from getsentry/sentry-dotnet#732 you are using it as a submodule and don't need a numbered NuGet release for this?

bruno-garcia commented 3 years ago

Wow thanks @benaadams !

I assume from getsentry/sentry-dotnet#732 you are using it as a submodule and don't need a numbered NuGet release for this?

Yeah, I'm good! :)