Add namespace to frame conditionally

[bruno-garcia]

If I'm not mistaken, adding an optional parameter is technically a breaking change. I could add an overload so that's not breaking if that's better.

Also, as you might recall, I'm consuming the package via git submodule so no need to publish just because of this change.

🙏

[benaadams]

If I'm not mistaken, adding an optional parameter is technically a breaking change.

Yeah, should forward the existing method instead?

// Forward existing method to introduce the default
public StringBuilder Append(StringBuilder builder)
    => Append(StringBuilder builder, fullName: true)

// New method
public StringBuilder Append(StringBuilder builder, bool fullName)
{
   // ...

[benaadams]

Might be issues with making the entire public api internal? 😅

[bruno-garcia]

lol @benaadams sorry pushed the wrong thing here :D

[benaadams]

Thank you!

[bruno-garcia]

Thank you! :)