search

benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)
Apache License 2.0
2.75k stars 118 forks source link

Add captured frames to EnhancedStackTrace #146

Open marwie opened 3 years ago

marwie commented 3 years ago

Injecting captured stackframes into EnhancedStackTrace

Example without injection in Unity context: Before 2021-02-25-093227

After 2021-02-25-093311

Example using sample in Unity context: Before: uncaughtsample-2021-02-25-093701

After: uncaughtsample-captured-2021-02-25-093754

benaadams commented 3 years ago

Hmm... test are not running. Let me look into that

bruno-garcia commented 3 years ago

I always assume those frames were "hidden" by design: image

marwie commented 3 years ago

It looks to me like they're not correctly parsed yet. I can include the code to the stacktrace tomorrow.

marwie commented 3 years ago

The code is here: https://gist.github.com/marwie/84efcd6a6a22f24208bba7abae13299b

niemyjski commented 5 months ago

@benaadams Any thoughts on merging this or other recent pr's?