benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)
Apache License 2.0
2.76k stars 118 forks source link

Assemblies in NuGet package are not signed with Authenticode #90

Open justRu opened 4 years ago

justRu commented 4 years ago

Is it possible to sign the assemblies with Authenticode ?

C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64>signtool verify "C:\Users\sezhezhe\.nuget\packages\ben.demystifier\0.1.4\lib\netstandard2.0\Ben.Demystifier.dll"
File: C:\Users\sezhezhe\.nuget\packages\ben.demystifier\0.1.4\lib\netstandard2.0\Ben.Demystifier.dll
Index  Algorithm  Timestamp
========================================
SignTool Error: No signature found.

Number of errors: 1
benaadams commented 4 years ago

Not sure it particularly worth the $499 per year?

justRu commented 4 years ago

Is it too much hassle to onboard this project to .NET Foundation and use their code signing service?

CADbloke commented 4 years ago

https://www.ksoftware.net/code-signing-certificates/ is cheaper and has worked well for me. They sell Comodo certs. @justRu you could sign it with your own cert like I do. Most of what I use from Nuget is unsigned so I sign it myself as part of the deployment build.