search

benaadams / Ben.Demystifier

High performance understanding for stack traces (Make error logs more productive)
Apache License 2.0
2.76k stars 118 forks source link

Allow external calling of ResolvedMethod/ResolvedParameter.Append() changing from private->public #99

Closed mitchcapper closed 3 years ago

mitchcapper commented 4 years ago

While ToString could be used if using in an external library that is building a stack trace calling the string builder method is more performant. I mainly have updated: https://github.com/mitchcapper/ProductionStackTrace to use it, but would like to change the line: https://github.com/mitchcapper/ProductionStackTrace/blob/8d5e4aacf84205755baa49fea7ddb2f83e3be967/ProductionStackTrace/ExceptionReporting.cs#L123

samtrion commented 4 years ago

This change should also be executed on the method ResolvedParameter.Apped(..). To keep it consistent.

mitchcapper commented 4 years ago

done

mitchcapper commented 4 years ago

Anything else required for merge?

mitchcapper commented 4 years ago

@benaadams do you think this will get merged? Would love to have it used in our library, otherwise we can figure out a work around.

benaadams commented 3 years ago

Thank you!