search

benaadams / System.Ben

Who says you can't be super fast and super secure
MIT License
142 stars 23 forks source link

Removes single quotes from README.md #67

Open bjorkstromm opened 7 years ago

bjorkstromm commented 7 years ago

Removes single quotes from README.md so that it works with our custom tool that inserts README file content to a SQL DB.

ping @benaadams

bjorkstromm commented 7 years ago

This is a must for us!!!

The README content of all third party dependencies that we use must be added to our SQL Database. And now we can't do that since it includes single quotes!!!!

bjorkstromm commented 7 years ago

Why is this not merged yet? Do I need to submit an issue?

benaadams commented 7 years ago

I think your db has a SQL injection issue

bjorkstromm commented 7 years ago

@benaadams no? SQL Injection? It's not my tool that is wrong, it's your README file that's not compatible, please accept this PR so I can use this library in our software.

Always the same, Github repos with non-working README files and people with apostrophes in their names complaining on how we sanitize our SQL statements.