search

benadida / helios-server

Helios server
http://heliosvoting.org
Apache License 2.0
721 stars 343 forks source link

Fix XSS described in Backes 2016 #300

Closed redfast00 closed 3 years ago

redfast00 commented 3 years ago

Implementation-level Analysis of the JavaScript Helios Voting Client describes an XSS attack in the Helios booth. This PR fixes that. See #225. Note that this PR does not prevent the booth from getting external URLs, as that might be seen as a feature.

I also don't guarantee the security of the rest of this project, this PR just fixes one XSS.

redfast00 commented 3 years ago

@benadida this is kind of security sensitive, can you please merge this PR?

redfast00 commented 3 years ago

Update: this is not enough to prevent XSS: see https://stackoverflow.com/a/29186757/5431090

redfast00 commented 3 years ago

Update: it might not be vulnerable anymore, I can't seem to reproduce the issue described in the paper

benadida commented 3 years ago

@redfast00 sorry for the long delay here, my sense is that there are no obvious XSS attacks on Helios anymore, but of course there may be some non-obvious ones, so please do feel free to send patches!