search

benadida / helios-server

Helios server
http://heliosvoting.org
Apache License 2.0
731 stars 349 forks source link

github usernames are case insensitive #362

Open lizthegrey opened 2 years ago

lizthegrey commented 2 years ago

https://github.com/benadida/helios-server/blob/master/helios_auth/auth_systems/github.py#L60-L66

it's fine to preserve the info exactly as pulled from GH but for comparison with voter rolls etc it should be okay for there to be discrepancies with the voter roll as uploaded as long as they differ only in case.

dyladan commented 1 year ago

I was just bit by this as well

dyladan commented 1 year ago

Maybe explaining the use case would help here:

I am administering the election for the OpenTelemetry Governance Committee. We generate the list of eligible voters by querying the CNCF devstats, which return github usernames normalized to lowercase. In our list of several hundred voters, i have no way of knowing which are supposed to have capital letters without querying the github API. Because GitHub does not allow multiple users to exist with usernames differing only in case, it should be safe to recognize when user ABC logs in, that they are the user abc in the voter roll.

jpkrohling commented 3 months ago

Any chance that this can be fixed soon? We have another OTel elections coming soon, and our data source exports data only in lowercase, which means we have a manual step for users with non lowercase-only chars as of their usernames.