RMS or RMSD - Githubissues

benalavi / waveform

Generate waveform images from audio files

197 stars 53 forks source link

RMS or RMSD #9

Closed cviedmai closed 12 years ago

cviedmai commented 12 years ago

hi,

looking at the source code, it looks like the method RMS is actually calculating the RMSD (root mean square deviation). Is this the intended behavior or a bug?

Thanks.

benalavi commented 12 years ago

Sorry for the delayed response, the intention was to calculate the RMS so that the generated waveform would look more like what you hear (eliminating very short peaks, pops, etc... that would be favored by the default peak method). I would not be at all surprised if I was calculating something different as I implemented it by refactoring another RMS calculation method, not by actually implementing the formula (shhh...), will take a look...

benalavi commented 12 years ago

Yup, fixed now by ccbb7ed9d15d4a15c73f476cd05e59b43d38a522, thanks!