search

benallfree / awesome-pocketbase

A collection of PocketBase community resources.
Creative Commons Zero v1.0 Universal
658 stars 44 forks source link

Update Repo for Adherence With awesome-lint #31

Closed jorgoose closed 9 months ago

jorgoose commented 9 months ago

Since this repo seems to be generally following the structure of the "Awesome" project (https://github.com/sindresorhus/awesome), I went ahead and made changes to the README that adhere to the guidelines outlined at https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md.

Adherence to guidelines was validated running the Awesome linter via "npx awesome-lint README.md".

With these changes, this repo should be able to be added to https://github.com/sindresorhus/awesome/blob/main/readme.md in a PR.

benallfree commented 9 months ago

This is so incredibly generous and helpful! I have to admit, I didn't even understand that there was an "awesome" format or hub of any kind, I thought it was just a loose ethos.

So after making these changes, we can submit a PR to get it included in the main directory?

jorgoose commented 9 months ago

Yep. I was looking at the main "Awesome" repo and noticed that PocketBase was not on there. The repo has 280k+ stars, and lots of newbies interested in programming / software engineering come across that repo.

I think it would be "awesome" (pun intended) if we got PocketBase on there!

And yes, the PR guidelines are here: https://github.com/sindresorhus/awesome/blob/main/pull_request_template.md

benallfree commented 9 months ago

⭐ for @jorgoose!

benallfree commented 9 months ago

@jorgoose would you be willing to do the PR to awesome, or does that feel a little out of scope? We'd love the help if you are able.

jorgoose commented 9 months ago

@benallfree Yeah I'm more than willing to. I can open the PR within the next day or so, will need to do reviews as per their guidelines.

jorgoose commented 9 months ago

Update: PR is opened, but looks like it didn't meet all of the guidelines. Working on double checking everything at the moment but a second pair of eyes could help:

https://github.com/sindresorhus/awesome/pull/2895

benallfree commented 9 months ago

I just looked through everything and didn't spot any issues either. Do we know what they are running to determine things were missed? Or was this a human review?