search

benank / everyone.dance

A realtime score sharing system for Stepmania. ⚠️ NOTE: This service is deprecated and no longer works, but you can still self host it.
https://everyone.dance
GNU General Public License v3.0
15 stars 1 forks source link

Installation only shows 1 of many theme versions #1

Closed kotutuloro closed 3 years ago

kotutuloro commented 3 years ago

I've got a few different versions of Simply Love saved in my themes. Annotation 2021-02-03 124025

During the everyone.dance installation, Simply Love only shows up once. Annotation 2021-02-03 124049

When I install it, it corresponds to the Simply Love-v4.9 theme folder (the last folder alphabetically).

Could everyone.dance account for themes with the same display name by also looking at the version info in ThemeInfo.ini? (Alternatively, I could just stop hoarding old theme versions lmao)

benank commented 3 years ago

Thanks for the report! Yeah, I can definitely look into adding version info for the themes as well.

geefr commented 3 years ago

I get a similar thing in the in-game theme selection - By default all different versions of a theme have the same name in their themeinfo file, so I end up editing the theme name so it shows in options menu

benank commented 3 years ago

Fixed. This + the other fix are included in release 1.0.4.

kotutuloro commented 3 years ago

I get a similar thing in the in-game theme selection - By default all different versions of a theme have the same name in their themeinfo file, so I end up editing the theme name so it shows in options menu

Weirdly enough, the Stepmania theme selection shows the theme's folder name instead of the display name for me, but I'm not really sure why lol

kotutuloro commented 3 years ago

Fixed

Shweet, thank you! Amazing job on this whole project btw!