search

benashford / redis-async-rs

A Rust client for Redis, using Tokio
Apache License 2.0
253 stars 30 forks source link

update tokio-util to 0.3 #52

Closed pandaman64 closed 4 years ago

pandaman64 commented 4 years ago

This may need a major version bump as tokio-util changed Encoder API.

benashford commented 4 years ago

Thanks for this!

I think this should be safe as a minor version as the Encoder itself isn't exposed anywhere, all clients would use RespValue on the boundaries of the library, so this won't break any dependencies (I hope).

benashford commented 4 years ago

Published in v0.6.3

pfrenssen commented 4 years ago

In the future it would perhaps be a good idea to only perform updates for required dependencies in minor releases. In patch releases it is best to not make any changes that break backwards compatibility.

fafhrd91 commented 4 years ago

this is breaking change and it shouldve be 0.7 release rather 0.6.3