Bugfix/issue 137

[Ryan-Florida]

Before submitting the PR, please make sure you do the following

• If this PR is related to an issue, so please reference it in your PR. This PR is related to Issue 137

• Please describe clearly what this PR solves in this message body. This PR solves a problem pertaining to dependencies within shared dependencies. If we consider what is implied by the file structure provided in the issue posting ( reposted here for reference:

  │  ├──ParticipantSetup
  │  │  ├──Area
  │  │  │  └──Area.module.scss
  │  │  ├──ParticipantSetupForm
  │  │  │  └──ConfigForm
  │  │  │     ├──CheckboxWithLabel
  │  │  │     │  └──CheckboxWithLabel.module.css
  │  │  │     ├──FormErrorMessage
  │  │  │     │  └──FormErrorMessage.module.scss
  │  │  │     ├──RadioBoxGroup
  │  │  │     │  └──RadioBoxGroup.module.css
  │  │  │     └──ConfigForm.module.css
  │  │  ├──ParticipantSetup.module.css
  │  │  └──ParticipantSetupForm.js
  │  ├──shared
  │  │  ├──Area.js
  │  │  ├──CheckboxWithLabel.js

  ), then we can quickly replicate the issue using the new shared-with-dependencies fixture. Using the shared-with-dependencies fixture, we get the following results:

• • with --avoid-single-file flag:

    ├── index
    │   ├── ParticipantSetup
    │   │   ├── ParticipantSetup.scss
    │   │   ├── ParticipantSetupForm
    │   │   │   ├── ConfigForm
    │   │   │   │   ├── ConfigForm.module.scss
    │   │   │   │   ├── RadioBoxGroup.js
    │   │   │   │   └── RadioBoxGroup.scss
    │   │   │   ├── ConfigForm.js
    │   │   │   └── ParticipantSetupForm.scss
    │   │   └── ParticipantSetupForm.js
    │   ├── ParticipantSetup.js
    │   ├── SomeOtherResource
    │   │   ├── Area
    │   │   │   ├── Area.config.js
    │   │   │   └── Area.module.scss
    │   │   ├── CheckboxWithLabel.scss
    │   │   └── SomeOtherResource.module.scss
    │   ├── SomeOtherResource.js
    │   └── shared
    │       ├── Area.js
    │       └── CheckboxWithLabel.js
    └── index.js"

• • without --avoid-single-file flag:

    ├── index
    │   ├── ParticipantSetup
    │   │   ├── ParticipantSetup.scss
    │   │   ├── ParticipantSetupForm
    │   │   │   ├── ConfigForm
    │   │   │   │   ├── ConfigForm.module.scss
    │   │   │   │   ├── RadioBoxGroup
    │   │   │   │   │   └── RadioBoxGroup.scss
    │   │   │   │   └── RadioBoxGroup.js
    │   │   │   ├── ConfigForm.js
    │   │   │   └── ParticipantSetupForm.scss
    │   │   └── ParticipantSetupForm.js
    │   ├── ParticipantSetup.js
    │   ├── SomeOtherResource
    │   │   ├── Area
    │   │   │   ├── Area.config.js
    │   │   │   └── Area.module.scss
    │   │   ├── CheckboxWithLabel
    │   │   │   └── CheckboxWithLabel.scss
    │   │   └── SomeOtherResource.module.scss
    │   ├── SomeOtherResource.js
    │   └── shared
    │       ├── Area.js
    │       └── CheckboxWithLabel.js
    └── index.js"

    Observe that, in both cases, the Area/ and CheckboxWithLabel/ directories remain within the SomeOtherResource directory, whereas we would expect them to be under shared/ with their respective .js counterparts.

Note for the observant: I know in the original posting they stayed within different folders but I introduced the SomeOtherResource directory to share the dependencies with since one was not necessarily implied in the original posting but this is the same problem just manifesting in a different way.

The underlying problem: When the method to collect shared resources runs, the paths of the sub-dependencies are not updated with the parent resource.

The solution: Recursively update sub-dependency paths.

• Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. I added a new shared-with-dependencies test fixture and updated existing tests (namely detect-lonely-files.test.ts, build-graph.test.ts, and to-fractal-tree.test.ts to account for it). detect-lonely-files.test.ts and to-fractal-tree.test.ts will fail with the new fixture. The work included in this branch will cause the tests to pass.

[codecov[bot]]

Codecov Report

Merging #161 (b32db99) into develop (155f3f5) will increase coverage by 0.14%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
+ Coverage    92.83%   92.97%   +0.14%     
===========================================
  Files           22       22              
  Lines          586      598      +12     
  Branches       140      141       +1     
===========================================
+ Hits           544      556      +12     
  Misses          42       42              

Impacted Files	Coverage Δ
src/index/generateTrees/toFractalTree.ts	86.66% <100.00%> (+1.72%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 155f3f5...b32db99. Read the comment docs.