search

benawad / destiny

Prettier for File Structures
MIT License
3.53k stars 79 forks source link

fix debugging jest tests in windows #165

Open roguib opened 3 years ago

roguib commented 3 years ago

Fixes https://github.com/benawad/destiny/issues/157#issuecomment-718917205 (only the part where I wasn't able to attach a debugger, resulting in a weird error).

After some research, I found this article with a launch.json configuration that wasn't failing when debugging Jest tests in windows.

Right now I can't test it in other OS, but let me know if the new configuration works for macOS since then we can safely remove the first one.

codecov[bot] commented 3 years ago

Codecov Report

Merging #165 (2ca2e72) into develop (3cfab83) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #165   +/-   ##
========================================
  Coverage    92.97%   92.97%           
========================================
  Files           22       22           
  Lines          598      598           
  Branches       141      141           
========================================
  Hits           556      556           
  Misses          42       42

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cfab83...7f6e7fe. Read the comment docs.

roguib commented 3 years ago

That's correct, it only fixes the part where I wasn't able to attach the debugger, but I have a guess what could be happening to the failing tests, I just need some time to work on it 😄 I've edited the PR to reflect that.

roguib commented 3 years ago

Sorry for the late reply. I've applied the mentioned changes, let me know if there's any problem debugging tests in macOS.