search

benawad / dogehouse

Taking voice conversations to the moon 🚀
https://dogehouse.tv/
MIT License
9.11k stars 1.48k forks source link

refactor(dolma): use switch instead of if in filterUnitoken.ts #2699

Closed MeztliRA closed 3 years ago

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

staging – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-staging/staging/12Yq6ZhWiwA8iXkaYMLhEE59LBpo
✅ Preview: Canceled

dogehouse – ./kibbeh

🔍 Inspect: https://vercel.com/benawad/dogehouse/41Px9DYdSQ5visZ4zrw3UN6brJMM
✅ Preview: https://dogehouse-git-fork-meztlira-patch-17-benawad.vercel.app

storybook – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/J33GodncxLahnfBwPCTemGDxrqRf
✅ Preview: Canceled

iamanalt commented 3 years ago

... why?

HoloPanio commented 3 years ago

Sorry but we're not going to be using switches, we will not have the values hard coded for much longer so we do not need to add a switch

amitojsingh366 commented 3 years ago

@HoloPanio the creator of dolma doesn't want switch statements so im gonna close this pr