benawad / dogehouse

Taking voice conversations to the moon 🚀
https://dogehouse.tv/
MIT License
9.11k stars 1.48k forks source link

Can't leave a room - button vanishes when reloading in new tab #2719

Open Akorian opened 3 years ago

Akorian commented 3 years ago

Dogehouse can't cope with the open in new tab functionality. There there is a way to make the "connection taken" page still play audio from the room, or make the leave room button disappear whilst in a room.

To Reproduce

  1. Enter a room
  2. open something in a new tab with middleklick
  3. audio gets played in the old tab in which you are redirected to the "connection taken" site. No leave button in the new tab

OR:

  1. Enter a room
  2. Open something in a new tab
  3. Enjoy audio without the opinion to leave the room.

Expected behavior No audio on the "connection taken" page. The room controls when I am in a room.

Demonstration: https://youtu.be/U_vps2TRnl4

What device are you on? I use chrome on Windows 10 Pro 64bit

amitojsingh366 commented 3 years ago

possibly linked to #2177

Akorian commented 3 years ago

I don't see the connection there. From my understanding, it is perfectly normal to be able to stay in a room while browsing the site. The issue for me is, that the "leave" button/ the whole "controls part", which normally is there when you aren't fullscreen in a room, is missing. check the vid.

BronzW commented 3 years ago

But isn't the sound coming from the original tab? It's what happened when I tried reproducing this

Akorian commented 3 years ago

That happens sometimes. Most of the time the sound source switches to the new tab. But the controls for leaving etc. are missing. (the video shows this)