benawad / dogehouse

Taking voice conversations to the moon 🚀
https://dogehouse.tv/
MIT License
9.12k stars 1.48k forks source link

kousa: fixes and improvements #2778

Closed amitojsingh366 closed 3 years ago

amitojsingh366 commented 3 years ago
vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

storybook – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-storybook/storybook/BbFBLxWjMPNUgQBBGdNBLwzuKpyW
✅ Preview: Canceled

[Deployment for c8a8792 canceled]

dogehouse – ./kibbeh

🔍 Inspect: https://vercel.com/benawad/dogehouse/DsuFbzJuLvGHvLu95dLLu3JjnrTD
✅ Preview: https://dogehouse-git-fork-amitojsingh366-patch-62-benawad.vercel.app

staging – ./kibbeh

🔍 Inspect: https://vercel.com/dogehouse-staging/staging/2RL3JYZZuQYyrR4qkggg7vgLW6bt
✅ Preview: Canceled

[Deployment for c8a8792 canceled]

willdoescode commented 3 years ago

I don't understand Elixir at all, but if will approves it, then it's LGTM

This fixes the bot mute exploit

pistasjis commented 3 years ago

ik

saihnii4 commented 3 years ago

i'm not sure that this fixes the exploit, it seems like it's a fix for search

willdoescode commented 3 years ago

i'm not sure that this fixes the exploit, it seems like it's a fix for search

it added if user_id == setter_id do which should make it so users can only set themselves

amitojsingh366 commented 3 years ago

why did my commit not trigger the workflow, @benawad what happened here

saihnii4 commented 3 years ago

it's being queued

https://github.com/benawad/dogehouse/actions/runs/846963472