benawad / dogehouse

Taking voice conversations to the moon πŸš€
https://dogehouse.tv/
MIT License
9.12k stars 1.48k forks source link

fix(profileheader): append username if displayName is not set #2855

Closed byeze closed 3 years ago

byeze commented 3 years ago

when people joins DogeHouse with an account that doesn't have a display name, ProfileHeader doesnt show any displayname. So, I appended the username of the user when displayname is not set

fix #226

BY ERROR: Added another commit of some translated strings

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

staging – ./kibbeh

πŸ” Inspect: https://vercel.com/dogehouse-staging/staging/25myzHeK5BBHLVmWEwytExoBurEi
βœ… Preview: Failed

[Deployment for 224c5da failed]

dogehouse – ./kibbeh

πŸ” Inspect: https://vercel.com/benawad/dogehouse/6sEPtzhheVxAVFYtbLpSstha9dLr
βœ… Preview: https://dogehouse-git-fork-byeze-staging-benawad.vercel.app

storybook – ./kibbeh

πŸ” Inspect: https://vercel.com/dogehouse-storybook/storybook/GEjBuJy1cF1dJRSCxnZGG2exzJQA
βœ… Preview: Canceled

[Deployment for 224c5da canceled]

amitojsingh366 commented 3 years ago

please follow the proper pattern for commit messages (πŸ’‘TIP: you can use yarn commit or yarn commit:signed and answer the questions asked to generate a properly formatted one for you!)

to fix your most recent commit you can run the command git commit --amend -m "properly formatted commit message here"

to fix your older/multiple commits please take a look at this article