search

benawad / type-graphql-series

Typescript GraphQL Server built with TypeGraphQL
326 stars 129 forks source link

Faker produces wrong Emails. #12

Open CodingForFunAndProfit opened 5 years ago

CodingForFunAndProfit commented 5 years ago

Hi,

I just wanted to tell you about this problem, I figured out after a while. Faker produces wrong gmail addresses with underscores in them. It is a known problem. So if anyone follows your videos and has a wrong faker version, the tests will fail from time to time, which is no fun. As a quick fix I just replaced underscores with periods from the generated email addresses. You can test it in the playground with and Email like: Rahsaan_Pollich@gmail.com and the answer will include "isEmail": "email must be an email".

You can close this issue immediately, I just thought it might be helpful for others if they encounter that problem and visit/search this git for a solution.

Cheers

benawad commented 5 years ago

thanks, I'll keep it open so more people see it