search

benawad / vsinder

Dating App for VSCode
Apache License 2.0
2.47k stars 174 forks source link

See amount of photos on app #178

Closed RazerMoon closed 3 years ago

RazerMoon commented 3 years ago

This adds #113 to the app, however it is not ready yet because there is a small transition issue. As the photos fade into each other, the indicator can be seen on both profiles. I am not entirely sure how to fix this issue, suggestions would be appreciated.

Demo:

https://user-images.githubusercontent.com/33849459/103027052-101bfc80-454d-11eb-9187-9bdc149141a6.mp4

benawad commented 3 years ago

What makes you think it's related to FullscreenImageZoom?

RazerMoon commented 3 years ago

Nevermind, I misinterpreted this call: https://github.com/benawad/vsinder/blob/b3f9958c5b30e2a3029e24c054ce1def2b80b176/packages/app/src/ui/CodeCard.tsx#L25 https://github.com/benawad/vsinder/blob/b3f9958c5b30e2a3029e24c054ce1def2b80b176/packages/app/src/ui/CodeCard.tsx#L120-L122

RazerMoon commented 3 years ago

The culprit seems to actually be the next image just not loading fast enough, which makes you see the images of the next profile and it's indicator

RazerMoon commented 3 years ago

But I'm not sure how you would fix that, maybe make the background behind the current images black? So even if they don't load fast enough, you won't get confused and think the next profile's image belongs to the current one

RazerMoon commented 3 years ago

This is with the background set to black, but it could be set to something else.

Before:

https://user-images.githubusercontent.com/33849459/103030898-a1db3800-4554-11eb-8ebf-4b0301f94e72.mp4

After:

https://user-images.githubusercontent.com/33849459/103030909-a99adc80-4554-11eb-91e7-d6acc4af9c31.mp4

benawad commented 3 years ago

I like it, are you adding anything else, or is this ready to merge?

RazerMoon commented 3 years ago

Should be good now, changed the bg color to the default bg of the app instead. Idk how I didn't think of doing that.

Should be ready to merge at this point, feel free to test yourself if you want to 👍

benawad commented 3 years ago

Use bg from current theme https://github.com/benawad/vsinder/blob/master/packages/app/src/ui/ScreenWrapper.tsx#L17

RazerMoon commented 3 years ago

Should be good now

https://user-images.githubusercontent.com/33849459/103032114-2dee5f00-4557-11eb-9b6a-334919ad129a.mp4