benbalter / jekyll-remote-theme

Jekyll plugin for building Jekyll sites with any GitHub-hosted theme
MIT License
291 stars 78 forks source link

Added GitHub Enterprise and Private GitHub support #83

Open chp9-u opened 4 years ago

chp9-u commented 4 years ago

A naive and working attempt to support both Github Enterprise Private and GitHub Private Repositories

welcome[bot] commented 4 years ago

Welcome! Congrats on your first pull request to Jekyll Remote Theme. If you haven't already, please be sure to check out the contributing guidelines.

chp9-u commented 4 years ago

resolves #81

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

chp9-u commented 3 years ago

I'd be curious to learn more about what workflow you're trying to solve for here. Enterprise Server support was added in #53.

We are hosting our GitHub Enterprise Server (2.21) with a custom internal DNS so it is not using the default github.<enterprise>.com. Our themes repos are also hosted internally and forced to be private by the administrators. Since we can't access anything on the server side, including the process of generating jekyll pages (we are a large organization), we can't rely on environment variables to pass the token to download the theme.