search

benbalter / sitemap-parser

Ruby Gem to parse sitemaps.org compliant sitemaps
MIT License
29 stars 46 forks source link

parse one level of sitemap-indexes #11

Open jeremybmerrill opened 8 years ago

jeremybmerrill commented 8 years ago

Hi Ben,

Hope you're doing well.

Interested in this PR? Would allow the gem to parse sitemaps with sub-sitemaps included. If I understand them correctly, it'd close both open issues.

I didn't write tests (yet? heh) but wanted to see if you were interested. Despite the lack of tests, this does indeed work. I'm using it in "production" ina small app that a couple people use.

benbalter commented 8 years ago

@jeremybmerrill I don't have a use for this project any more, so if this PR helps you, glad to merge it (with tests) and cut a new release. :smile:

alexmuller commented 8 years ago

I'd really appreciate this feature for GOV.UK. If you don't get the chance to write tests for this change I'm happy to give it a go. It's always lovely to find a project and see that somebody has done most of the work for a feature you want, so thank you!

jeremybmerrill commented 8 years ago

@alexmuller: tbqh, writing tests for this isn't ever going to bubble up high enough on my todo list for it to get done... So, it's all yours and I hope it's useful! Let me know if there's anything I can do to help.

alexmuller commented 8 years ago

Thanks! I've had a go in #12.