Enable to parse local sitemap regardless of filename

benbalter / sitemap-parser

Ruby Gem to parse sitemaps.org compliant sitemaps

MIT License

29 stars 46 forks source link

Enable to parse local sitemap regardless of filename #15

Open tsmsogn opened 7 years ago

tsmsogn commented 7 years ago

This PR has following features.

Enable to parse local sitemap regardless of file name
Fixes #14

benbalter commented 7 years ago

Based on the error in #14, I wonder if we need to call File.expan_path on @url such that the URL is prefexed by a / in all cases.

tsmsogn commented 7 years ago

Thank you for your reply.

Should I close this PR, then split this PR into two PRs? One fixes #14 with File.expan_path, and the other enables to parse sitemap regardless of file name.

benbalter commented 7 years ago

and the other enables to parse sitemap regardless of filename

Can you explain a bit more about why you need to do that?

tsmsogn commented 7 years ago

Can you explain a bit more about why you need to do that?

There are two reasons.

I think sitemap can have various file name. For example, It is used in sitemap index.
I'd like to parse sitemap in local regardless of file name.