benbalter / sitemap-parser

Ruby Gem to parse sitemaps.org compliant sitemaps
MIT License
29 stars 46 forks source link

Remove breaking reference to version #22

Closed trcarden closed 2 years ago

trcarden commented 3 years ago

Not sure if the reference to the version is required or not.

Pulling to fix: https://github.com/benbalter/sitemap-parser/issues/21

yubele commented 2 years ago

@trcarden

The following fix is required to resolve this issue.

https://github.com/benbalter/sitemap-parser/pull/23/files#diff-2f97e4f10c2cb3e2015c89e567e1bcfdfd3abceea6cc6f68401c2cf050436950L14

I actually downloaded the gem, but the version.rb was not included.

@yubele ➜ /workspaces/tmp $ wget https://rubygems.org/downloads/sitemap-parser-0.5.0.gem
--2021-12-14 12:15:01--  https://rubygems.org/downloads/sitemap-parser-0.5.0.gem
Resolving rubygems.org (rubygems.org)... 151.101.65.227, 151.101.193.227, 151.101.1.227, ...
Connecting to rubygems.org (rubygems.org)|151.101.65.227|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 5120 (5.0K) [application/octet-stream]
Saving to: ‘sitemap-parser-0.5.0.gem’

sitemap-parser-0.5.0.gem                          100%[===========================================================================================================>]   5.00K  --.-KB/s    in 0s      

2021-12-14 12:15:01 (21.2 MB/s) - ‘sitemap-parser-0.5.0.gem’ saved [5120/5120]

@yubele ➜ /workspaces/tmp $ tar xf sitemap-parser-0.5.0.gem 
@yubele ➜ /workspaces/tmp $ tar zxf data.tar.gz 
@yubele ➜ /workspaces/tmp $ ls 
checksums.yaml.gz  data.tar.gz  lib  metadata.gz  sitemap-parser-0.5.0.gem

@yubele ➜ /workspaces/tmp $ ls lib/
sitemap-parser.rb
@yubele ➜ /workspaces/tmp $ 
GitHub
Fixed a require error. by yubele · Pull Request #23 · benbalter/sitemap-parser
When I tried to use sitemap-parser using gem install, I couldn't require it, so I'll fix it in this PR. My environment is as follows. @yubele ➜ /workspaces/sitemap-parser (fix/require) $ ru...
benbalter commented 2 years ago

This should now be fixed via https://github.com/benbalter/sitemap-parser/pull/23.