search

benbalter / sitemap-parser

Ruby Gem to parse sitemaps.org compliant sitemaps
MIT License
29 stars 46 forks source link

Make sure that we respect the option to recurse within a recursion #25

Closed etagwerker closed 2 years ago

etagwerker commented 2 years ago

Hi there,

When setting recurse: true I would expect it to remain true all the way down to the deepest levels of recursion.

This fixes https://github.com/benbalter/sitemap-parser/issues/10

Please check it out and let me know what you think.

Thanks, Ernesto

benbalter commented 2 years ago

Thanks for this @etagwerker! 🎉

benbalter commented 2 years ago

@etagwerker It looks like merging in master caused two Rubocop failures. If you're able to resolve them (or add them to the rubocop todo file), I'd be happy to get this merged.

etagwerker commented 2 years ago

@benbalter Thanks for looking into this! I added them to the rubocop todo file because I think the cons outweigh the pros of addressing those two complaints.