search

benbaran / adal-angular4

Angular 4/5/6/7 ADAL Wrapper
MIT License
86 stars 104 forks source link

Support for Angular 7 #106

Closed ravivit9 closed 5 years ago

ravivit9 commented 5 years ago

HI, At the moment I am using adal-angular6 version which is failing up on upgrading Angular to version 7.

I would like to know future plans to support Angular 7 version.

Thanks, Ravindra.

benbaran commented 5 years ago

I was able to use it today in an Angular 7 project. Where is it failing for you?

Sent from my iPhone

On Dec 6, 2018, at 3:39 AM, Ravi notifications@github.com wrote:

HI, At the moment I am using adal-angular6 version which is failing up on upgrading Angular to version 7.

I would like to know future plans to support Angular 7 version.

Thanks, Ravindra.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ravivit9 commented 5 years ago

Hi Ben, Thanks for your reply.

I was using adal-angular6. Before I start to use adal-angular4 I wanted to ensure this adal-angular4 supports Angular 7.

I will update this ticket once I implement this.

Thanks.

ravivit9 commented 5 years ago

Hi @benbaran, I uninstalled adal-angular6 and intstalled adal-angular4 and upgraded to angular 7 as suggested in the readme file. I am not sure whether adal-angular4 supports http get, patch, post and delete methods similar to adal-angular6.

Thanks.

benbaran commented 5 years ago

It uses the native HttpClient, so it will support all operations. Be sure to follow the adal-angular-6-example to get the HTTP_INTERCEPTORS set up properly to send the token with the requests.

ravivit9 commented 5 years ago

Hi @benbaran, I am getting the following error after upgrading to angular 7 using adal-angular6. That's the reason I am looking for another solution to sort this out.

screenshot 2018-12-12 at 11 54 10
benbaran commented 5 years ago

That’s not my library, so I can’t speak to it, unfortunately. This one (adal-angular4) does work with Angular 7 though. The example project has been updated, and I tested it yesterday.

Sent from my iPhone

On Dec 12, 2018, at 6:55 AM, Ravi notifications@github.com wrote:

Hi @benbaran, I am getting the following error after upgrading to angular 7 using adal-angular6. That's the reason I am looking for another solution to sort this out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ravivit9 commented 5 years ago

Hi, @benbaran, now I have uninstalled the adal-angular6 and using yours. it's working fine. Thanks for your support.

akshayantony commented 5 years ago

Hi @benbaran, i checkedout the adal-angular4 code from link and performed the commands as in the read me file. How can i run the code? When i execute ng serve command, i am getting this error The serve command requires to be run in an Angular project, but a project definition could not be found.. It may be because your code doesnot have angular.json or angular-cli.json file. Please help