search

benbaran / adal-angular4

Angular 4/5/6/7 ADAL Wrapper
MIT License
86 stars 104 forks source link

handleWindowCallback() doesn't renew id_token #18

Closed eKipod closed 6 years ago

eKipod commented 7 years ago

In handleWindowCallback, if renew succeeds for anything but 'access_token', nothing happens (leaving e.g. acquireToken() hanging). Should there be a case for handling 'id_token'? Should there be a catch-all error callback invocation?

alan-g-chen commented 6 years ago

I ran into the same issue, and have submitted a PR to fix it.

geerzo commented 6 years ago

Closing as an old issue that appears to have been solved. Please post a new issue if there is still an issue here.