search

benbaran / adal-angular4

Angular 4/5/6/7 ADAL Wrapper
MIT License
86 stars 104 forks source link

Angular 6 #41

Closed rjwijnen closed 6 years ago

rjwijnen commented 6 years ago

With the release of Angular 6 i get the warning:

npm WARN adal-angular4@2.0.15 requires a peer of @angular/common@^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of @angular/core@^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of @angular/platform-browser@^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of @angular/router@^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of rxjs@^5.5.6 but none is installed. You must install peer dependencies yourself.

Maybe update the packages and files to support Angular 6?

benbaran commented 6 years ago

The package has been updated to support Angular 6 in the 3.x version.

On May 4, 2018, at 1:33 AM, rjwijnen notifications@github.com wrote:

With the release of Angular 6 i get the warning:

npm WARN adal-angular4@2.0.15 requires a peer of @^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of @^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of @^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of @^5.2.5 but none is installed. You must install peer dependencies yourself. npm WARN adal-angular4@2.0.15 requires a peer of rxjs@^5.5.6 but none is installed. You must install peer dependencies yourself.

Maybe update the packages and files to support Angular 6?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

kaburkett commented 6 years ago

Thanks for maintaining the project. I've confirmed 3.x is working with angular 6... had to actually switch packages from adal-angular5 to this package since this one is the one that's actually maintained